-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[WIP][POC] ✨ Remove CR dependency in API packages #12820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
42ca147
to
a4a3c90
Compare
a4a3c90
to
cefa7d9
Compare
@sbueringer: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
so in short are we aiming to refactor conversion logic to make zz_* generated files more generic across the project (which would solve etcd issues mentioned such as old object vs new object in the KV store) especially if we're talking external apis - does it relate to kubernetes-sigs/controller-runtime#3335? And real qeustion is going to be how to properly convert Changed Resource Versions issues for external apis since there is not straight forward of doing this due to the state, so it seems as the effort for modularization in a form of submodules. I'd look at tests deeper to make sure they are properly adopted since quite of a logic was moved but I agree 100 that addons should be separate for the user. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #